sign up issues if user enters enter multiple spaces in first name #2358 #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Astitva877
requested changes
Jan 10, 2025
There was a problem hiding this comment.
@0mahendra you have pushed the same code in two different PRs, whenever you make a new branch make it from development not from existing PR.
Astitva877
reviewed
Jan 13, 2025
| @@ -81,7 +81,7 @@ | |||
| try { | |||
| const magicCodeResponse = await sendMagicCodeEmail({ email }); | |||
| if (magicCodeResponse.isSuccessful) { | |||
| navigate(`/verify-magic-code/${email}`); // Updated this line | |||
| navigate(`/verify-magic-code/${email}/${magicCodeResponse.data}`); // Updated this line | |||
There was a problem hiding this comment.
why we have this changes in this PR also, i think you have already raised a PR for this.
Astitva877
reviewed
Jan 13, 2025
| {:else if authenticationError} | ||
| <small class="form-text text-dangerColor" | ||
| <small class="form-text text-dangerColor email_and_password_error" |
There was a problem hiding this comment.
also remove this, it has been already fixed in different branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sign up issues if user enters enter multiple spaces in first name
#2358
1.Enter new email id in email field
2.Click on continue
3.Enter multiple spaces and then user first name
4.Fill up remaining information
5.Verify OTP
Bug 1-
Expected-
The user's first name should be present in the verification mail
Actual-
First name is not present as user provided spaces in first name
Bug 2
Expected-
team name should come properly after sign up
Actual-
Team name only contain '
https://techdome-my.sharepoint.com/:v:/g/personal/shreyas_pharande_techdome_net_in/ETjqjEQw3PFOpVK8DPQ-oYoBAPmf8vRCY_NEbMUhzejUxw?e=8jr9WI
after solving the bug
https://techdome-my.sharepoint.com/:v:/g/personal/mahendra_singh_techdome_net_in/EannLDQWUSNKu9GGw6pRdq4BFFiQIwkfBX2JJeILR-RBUQ?nav=eyJyZWZlcnJhbEluZm8iOnsicmVmZXJyYWxBcHAiOiJTdHJlYW1XZWJBcHAiLCJyZWZlcnJhbFZpZXciOiJTaGFyZURpYWxvZy1MaW5rIiwicmVmZXJyYWxBcHBQbGF0Zm9ybSI6IldlYiIsInJlZmVycmFsTW9kZSI6InZpZXcifX0%3D&e=ANN35n